feat(mro): Improve martian_make_mro #498
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Include the filename in the error message of martian_make_mro.
sreenathkrishnan
approved these changes
Jun 12, 2024
| ); | ||
| ensure!( | ||
| rewrite || !filename.exists(), | ||
| "File {} exists. Use --rewrite to overwrite it.", |
There was a problem hiding this comment.
--rewrite is a caller specific detail, but this is valid for all our use cases
sjackman
force-pushed
the
sj/martian_make_mro
branch
from
3c5e88f to
6c63611
Compare
This change did a cause change in the MRO files produced by the tests, though it was fine for the non-test code. I've reverted this change for now. I may take another look at it in a separate PR. |
| let args: Vec<_> = std::env::args().collect(); | ||
| std::path::Path::new(&args[0]) | ||
| Path::new(&std::env::args().next().unwrap()) | ||
| .canonicalize() |
There was a problem hiding this comment.
Please revert this. Cannonicalization makes this function essentially useless in a bazel runfiles tree.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
martian_make_mrocurrent_executableas fallback inget_generator_namecurrent_executableSlack: https://10xgenomics.slack.com/archives/CJT1RB554/p1717443208330939